Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require whitespace before description with limited start tokens #128

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

rvanvelzen
Copy link
Contributor

Fixes #125

@rvanvelzen rvanvelzen marked this pull request as ready for review June 8, 2022 13:18
@ondrejmirtes
Copy link
Member

I really like this! I'm gonna check the integration tests in PHPStan before tagging a release here because there might be some real-world impact.

@ondrejmirtes ondrejmirtes merged commit d579798 into phpstan:1.5.x Jun 8, 2022
@ondrejmirtes
Copy link
Member

Thank you!

new PhpDocTagNode(
'@return',
new InvalidTagValueNode(
'\Closure(...int, string): string',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for throwing at least

as all other types in \Closure phpdoc does not require a variable name, can support for unnamed variadic phpdoc be added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is already supported, but the type always has to come first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know, thank you ❤️

@rvanvelzen rvanvelzen deleted the description-ws branch June 8, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnamed vargs type in callable/Closure phpdoc is silently ignored
3 participants